Ghidra: Basic Block Feature Extraction #1637
Conversation
There was a problem hiding this comment.
Great progress @colton-gabertan ! It's cool to see you digging deeper into Ghidra's scripting API! I've left comments for your review.
| def get_printable_len(op: ghidra.program.model.scalar.Scalar) -> int: | ||
| """Return string length if all operand bytes are ascii or utf16-le printable""" | ||
| op_bit_len = op.bitLength() | ||
| op_val = op.getValue() |
There was a problem hiding this comment.
Since we are dealing with printable characters, should we be using getUnsignedValue here instead?
There was a problem hiding this comment.
I didn't want it to ever return a NoneType, and the &'s handle the conversion to an unsigned int. I was thinking that the NoneTypes would cause crashes.
There was a problem hiding this comment.
That makes sense - I'm not seeing anywhere in Ghidra's documentation where getUnsignedValue may return None? Did you find this was the case during testing?
mike-hunhoff
added
ghidra
| def get_printable_len(op: ghidra.program.model.scalar.Scalar) -> int: | ||
| """Return string length if all operand bytes are ascii or utf16-le printable""" | ||
| op_bit_len = op.bitLength() | ||
| op_val = op.getValue() |
There was a problem hiding this comment.
That makes sense - I'm not seeing anywhere in Ghidra's documentation where getUnsignedValue may return None? Did you find this was the case during testing?
Checklist
Implements #1510 - Ghidra: Basic Block Feature Extraction